Hello Vitor de Lima,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/29502
to review the following change.
Change subject: core, engine: Fix HotPlugCpuSupported config value
......................................................................
core, engine: Fix HotPlugCpuSupported config value
The 'HotPlugCpuSupported' configuration value was not present in the
database and another unused property called HotPlugCpuEnable contained
syntax errors that prevented it from being read by the JSON parser.
This patch removes the unused property and adds the correct one, fixing
the syntax errors that were present.
Change-Id: I3ef5b2e39b2067239721a65b031d247ace3b0c2c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1069802
Signed-off-by: Vitor de Lima <[email protected]>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 7 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/29502/1
diff --git a/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
b/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
index 9ea49e2..9dc11e7 100644
--- a/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
+++ b/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
@@ -190,22 +190,18 @@
select fn_db_add_config_value('HostPreparingForMaintenanceIdleTime', '300',
'general');
select fn_db_add_config_value('HostTimeDriftInSec','300','general');
select fn_db_add_config_value('HotPlugEnabled','false','3.0');
-select
fn_db_add_config_value('HotPlugCpuEnabled','{\"x86_64\":\"false\",\"ppc64\":\"false\"}','3.0');
-select
fn_db_add_config_value('HotPlugCpuEnabled','{\"x86_64\":\"false\",\"ppc64\":\"false\"}','3.1');
-select
fn_db_add_config_value('HotPlugCpuEnabled','{\"x86_64\":\"false\",\"ppc64\":\"false\"}','3.2');
-select
fn_db_add_config_value('HotPlugCpuEnabled','{\"x86_64\":\"false\",\"ppc64\":\"false\"}','3.3');
-select
fn_db_add_config_value('HotPlugCpuEnabled','{\"x86_64\":\"true\",\"ppc64\":\"false\"}','3.4');
-select
fn_db_add_config_value('HotPlugCpuEnabled','{\"x86_64\":\"true\",\"ppc64\":\"false\"}','3.5');
-
+select
fn_db_add_config_value('HotPlugCpuSupported','{"x86_64":"false","ppc64":"false"}','3.0');
+select
fn_db_add_config_value('HotPlugCpuSupported','{"x86_64":"false","ppc64":"false"}','3.1');
+select
fn_db_add_config_value('HotPlugCpuSupported','{"x86_64":"false","ppc64":"false"}','3.2');
+select
fn_db_add_config_value('HotPlugCpuSupported','{"x86_64":"false","ppc64":"false"}','3.3');
+select
fn_db_add_config_value('HotPlugCpuSupported','{"x86_64":"true","ppc64":"false"}','3.4');
+select
fn_db_add_config_value('HotPlugCpuSupported','{"x86_64":"true","ppc64":"false"}','3.5');
-- migration support per architecture
select fn_db_add_config_value('IsMigrationSupported','{"undefined": "true",
"x86_64": "true", "ppc64" : "false" }','general');
-
-- snapshot support per architecture
select fn_db_add_config_value('IsMemorySnapshotSupported','{"undefined":
"true", "x86_64": "true", "ppc64" : "false" }','general');
-
-- suspend support per architecture
select fn_db_add_config_value('IsSuspendSupported','{"undefined": "true",
"x86_64": "true", "ppc64" : "false" }','general');
-
select fn_db_add_config_value('MigrationSupportForNativeUsb','false','3.0');
select fn_db_add_config_value('MigrationSupportForNativeUsb','false','3.1');
select fn_db_add_config_value('NetworkLinkingSupported','false','3.0');
@@ -1089,8 +1085,7 @@
select fn_db_delete_config_value('UknownTaskPrePollingLapse','general');
select fn_db_delete_config_value('GlusterAysncTasksSupport','3.0,3.1,3.2,3.3');
select fn_db_delete_config_value('NormalizedMgmgNetworkEnabled','3.0,3.1,3.2');
-
-
+select
fn_db_delete_config_value('HotPlugCpuEnabled','3.0,3.1,3.2,3.3,3.4,3.5');
------------------------------------------------------------------------------------
-- Split config section
-- The purpose of this section is to treat config option that was once
--
To view, visit http://gerrit.ovirt.org/29502
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ef5b2e39b2067239721a65b031d247ace3b0c2c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
