Juan Hernandez has posted comments on this change. Change subject: restapi - Fix Display VM Session Info (#894027) ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29506/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmSessionsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmSessionsResource.java: Line 58: addLinks(session, org.ovirt.engine.api.model.VM.class); Line 59: session.getUser().setDomain(new Domain()); Line 60: session.getUser().getDomain().setName(domainName); Line 61: setSessionUser(session); Line 62: // setSessionUserDomain(session); Remove this comment. Line 63: } Line 64: Line 65: private void setSessionVmId(org.ovirt.engine.api.model.VM vmModel, Session session) { Line 66: session.setVm(vmModel); Line 87: */ Line 88: private void setSessionUser(Session session) { Line 89: User user = Line 90: getUserResource().getUserByNameAndDomain(session.getUser().getUserName(), Line 91: session.getUser().getDomain().getName()); I'd suggest to check if the returned user is null. That can happen if the user has been removed from the users table but its name@domain is still in the vm_dynamic table. Line 92: session.getUser().setId(user.getId()); Line 93: session.getUser().setHref(user.getHref()); Line 94: session.getUser().getDomain().setId(user.getDomain().getId()); Line 95: session.getUser().getDomain().setHref(user.getDomain().getHref()); -- To view, visit http://gerrit.ovirt.org/29506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I034c93fe0c5037771dc9ed12d64ca5deea10957f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
