Lior Vernia has uploaded a new change for review. Change subject: webadmin: Change trigger for VnicProfileWidget ValueChangeEvent ......................................................................
webadmin: Change trigger for VnicProfileWidget ValueChangeEvent VnicProfileWidget used to listen on its nameEditor's ValueChangeEvent in order to fire a ValueChangeEvent on its own. However, when the nameEditor's value was changed programmatically from its model, UiCommonEditorVisitor would call an overload of nameEditor.setValue() that would set the value without firing a ValueChangeEvent. This patches registers directly to the model, so that the programmatical change on the model side would trigger a ValueChangeEvent of VnicProfileWidget. Change-Id: I330c38ecedb0df6433491bedaeb7afdc2bd11ae5 Bug-Url: https://bugzilla.redhat.com/1114971 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/29526/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java index c366f06..54f47fe 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java @@ -10,6 +10,9 @@ import org.ovirt.engine.ui.common.widget.renderer.NullSafeRenderer; import org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractModelBoundPopupWidget; import org.ovirt.engine.ui.uicommonweb.models.profiles.VnicProfileModel; +import org.ovirt.engine.ui.uicompat.Event; +import org.ovirt.engine.ui.uicompat.EventArgs; +import org.ovirt.engine.ui.uicompat.IEventListener; import org.ovirt.engine.ui.webadmin.ApplicationConstants; import org.ovirt.engine.ui.webadmin.ApplicationResources; import org.ovirt.engine.ui.webadmin.ApplicationTemplates; @@ -108,9 +111,9 @@ }); } }); - nameEditor.asValueBox().addValueChangeHandler(new ValueChangeHandler<String>() { + model.getName().getEntityChangedEvent().addListener(new IEventListener() { @Override - public void onValueChange(ValueChangeEvent<String> event) { + public void eventRaised(Event ev, Object sender, EventArgs args) { ValueChangeEvent.fire(VnicProfileWidget.this, model); } }); -- To view, visit http://gerrit.ovirt.org/29526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I330c38ecedb0df6433491bedaeb7afdc2bd11ae5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
