Alona Kaplan has posted comments on this change. Change subject: engine: move speed property from VdsNetworkInterface to VdsNetworkStatistics ......................................................................
Patch Set 11: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28913/11/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java: Line 295: entity.getStatistics().setReceiveDropRate(rs.getDouble("rx_drop")); Line 296: entity.getStatistics().setTransmitDropRate(rs.getDouble("tx_drop")); Line 297: entity.getStatistics().setStatus(InterfaceStatus.forValue(rs.getInt("iface_status"))); Line 298: entity.getStatistics().setVdsId(getGuidDefaultEmpty(rs, "vds_id")); Line 299: entity.getStatistics().setSpeed((Integer) rs.getObject("speed")); You can use- rs.getInt("speed") instead of the casting Line 300: Line 301: entity.setType((Integer) rs.getObject("type")); Line 302: entity.setGateway(rs.getString("gateway")); Line 303: entity.setSubnet(rs.getString("subnet")); -- To view, visit http://gerrit.ovirt.org/28913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4be28a786bee1eae6367c4ef19c9ee3b4afec61 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
