Martin Mucha has posted comments on this change. Change subject: tools: support for deprecating config values. ......................................................................
Patch Set 2: (1 comment) answers. http://gerrit.ovirt.org/#/c/29295/2/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java: Line 503: String message = null; Line 504: boolean res = true; Line 505: Line 506: if (configKey.isDeprecated()) { Line 507: throw new IllegalAccessError("ConfigKey " + key + " is deprecated. Please refer to product documentation."); > I'd write: Done Line 508: } Line 509: Line 510: try { Line 511: configKey.safeSetValue(value); -- To view, visit http://gerrit.ovirt.org/29295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I636f7fe2530acfe00d8f0487001ddc781d1745a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
