Alon Bar-Lev has posted comments on this change. Change subject: node: Determine node version ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29503/2/src/plugins/ovirt-host-deploy/node/node_ver.py File src/plugins/ovirt-host-deploy/node/node_ver.py: Line 54: len(part) > 0 and Line 55: part[0].isdigit() Line 56: ): Line 57: # 1st part starting with number should be version Line 58: version = part > Yes, but we need this for 3.5 and it means now. For next version we can imp nope. 3.5 is not out, we can add trivial stuff like this. Line 59: break Line 60: except (IOError, OSError, ValueError): Line 61: self.logger.debug( Line 62: 'Error getting node version', -- To view, visit http://gerrit.ovirt.org/29503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfa4fb729cb2db3fba9076a1184d2906cee06868 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
