Sahina Bose has posted comments on this change. Change subject: restapi: update API for Gluster Volume and Brick ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/25819/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java: Line 116: } Line 117: Line 118: @Override Line 119: public GlusterBrick update(GlusterBrick incomingBrick) { Line 120: validateParameters(incomingBrick, "id", "status"); We also need a reason for update - this could be populated in status.detail and needs to be validated, The reason for update needs to be logged in Audit log Line 121: QueryIdResolver<Guid> brickResolver = Line 122: new QueryIdResolver<Guid>(VdcQueryType.GetGlusterBrickById, IdQueryParameters.class); Line 123: GlusterBrickEntity entity = getEntity(brickResolver, true); Line 124: return performUpdate(incomingBrick, http://gerrit.ovirt.org/#/c/25819/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java: Line 197: } Line 198: Line 199: @Override Line 200: public GlusterVolume update(GlusterVolume incomingVolume) { Line 201: validateParameters(incomingVolume, "id", "status"); same as for brick resource Line 202: QueryIdResolver<Guid> volumeResolver = new QueryIdResolver<Guid>(VdcQueryType.GetGlusterVolumeById, IdQueryParameters.class); Line 203: GlusterVolumeEntity entity = getEntity(volumeResolver, true); Line 204: return performUpdate(incomingVolume, Line 205: entity, -- To view, visit http://gerrit.ovirt.org/25819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia67e8e0ae7c2c583e99ac98ac176df6b3bdcbcb6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
