Oved Ourfali has posted comments on this change. Change subject: ui: improve hot plug cpu wording ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29436/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java: Line 148: String migrationDowntimeInfo(Integer milliseconds); Line 149: Line 150: @DefaultMessage("Hot add CPUs by changing the number of sockets." + Line 151: " Please consult documentation for your guest operating system to ensure it has proper support for CPU Hot Add") Line 152: String hotPlugUnplugCpuWarning(); Is the warning used only when plugging or also when unplugging? I'd write: Hot plug/unplug CPUs by changing the number of sockets. Please consult documentation for your guest operating system to ensure it has proper support for this functionality. -- To view, visit http://gerrit.ovirt.org/29436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8013172ee5410330bad4bfc8f5560ed1eef7988a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
