Juan Hernandez has posted comments on this change. Change subject: packaging: Moved "MY_NAME" const to basedefs ......................................................................
Patch Set 1: (1 inline comment) Not really related to this change, but I think that MY_NAME is not very descriptive. Is the name of what? Certainly not my name. What if you change it to ENGINE_NAME, or something similar (maybe in a different patch)? .................................................... File packaging/fedora/setup/output_messages.py Line 22: MY_NAME=basedefs.MY_NAME I assume that you are doing this in order to avoid replacing MY_NAME with basedefs.MY_NAME, but it is not a lot of places. Can we do it? -- To view, visit http://gerrit.ovirt.org/5777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1113ad02b989aa559fe526d1ed94e511278fe724 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
