Roy Golan has posted comments on this change. Change subject: core: inject Config in AddVmCommand ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29606/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/BllCDIAdapter.java: Line 55: Line 56: @Produces @ConfigValue Line 57: public String produceStringConfigValue(InjectionPoint injectionPoint) { Line 58: return config.get(injectionPoint.getAnnotated().getAnnotation(ConfigValue.class).value()); Line 59: } its actually quite easy to create producers for whatever config we want without changing the config code @Produces @Json public String produceJson(InjectionTarget it) { get string value... return (make json from string) } Line 60: Line 61: Line 62: private BllCDIAdapter() { Line 63: // hide me -- To view, visit http://gerrit.ovirt.org/29606 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4819c34dc3068482bb56604c0a1c522b6148f757 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
