Gilad Chaplik has posted comments on this change. Change subject: db, core: aggregate qos and storage qos impl ......................................................................
Patch Set 18: (1 comment) minor fix while rebasing. Thanks Liron. http://gerrit.ovirt.org/#/c/27094/18/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/StorageQosDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/qos/StorageQosDaoTest.java: Line 57: storageQos.setMaxWriteThroughput(30); Line 58: storageQos.setMaxIops(30); Line 59: storageQos.setMaxReadIops(30); Line 60: storageQos.setMaxWriteIops(30); Line 61: assertThat(storageQos, not(equalTo(dao.get(FixturesTool.QOS_ID_2)))); > as discussed on last patchset, please change to assertFalse(storageQos.equa don't think that I agreed to that :-) but okay Done. Line 62: dao.update(storageQos); Line 63: StorageQos fetched = dao.get(FixturesTool.QOS_ID_2); Line 64: assertNotNull(fetched); Line 65: assertEquals(storageQos, fetched); -- To view, visit http://gerrit.ovirt.org/27094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d63b Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
