Oved Ourfali has posted comments on this change. Change subject: tools: (WIP, review don't submit) Adding Reload Configs Implementation ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (4 inline comments) Some minor comments. Make sure Moti reviews as well. Oved .................................................... File backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java Line 53: private static final String REST_SERVLET_URL = "%s://%s/api/reloadconfigurations"; shouldn't it be reloadconfiguration and not reloadconfigurations? Line 542: return getConfigDAO().getKey(keyStorePassKey); Consider wrapping it in a method that gets the key. Use it in the getKeystorePassKey and getKeystoreUrlKey methods. Line 560: serverAddress = appConfig.getString(SECURED_ENGINE_ADDRESS); can it be empty? Line 565: serverAddress = appConfig.getString(ENGINE_ADDRESS); can it be empty? -- To view, visit http://gerrit.ovirt.org/4951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9e790d7a8386359edfd62172df1078da033e91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
