Yaniv Bronhaim has posted comments on this change. Change subject: ui: Clean fields and load new provider info when selected provider is changed ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29639/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java: Line 52: if (getIsDiscorveredHosts().getEntity() != null) { Line 53: updateHostList(getIsDiscorveredHosts().getEntity()); Line 54: } else { Line 55: // Before we picked discovered or not, load all Line 56: updateHostList(true); > can we load data only radio button selection? i.e. load data only when clic no, you also switch providers. I prefer that the radio buttons will control only on the visibility. and switching provider will load the hosts info. I'll remove the update function to load everything in each call, will be much easier to understand Line 57: updateHostList(false); Line 58: } Line 59: } Line 60: }); -- To view, visit http://gerrit.ovirt.org/29639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie01a6c8b6d6f7e58a6057fc211ab5e4605bbe310 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
