Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Protocol decision based on cluser compatibility version ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/29123/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java: Line 263: Config.<Boolean> getValue(ConfigValues.EncryptHostCommunication)); Line 264: VdsStatic vdsStatic = getParameters().getVdsStaticData(); Line 265: if (vdsStatic.getProtocol() == null) { Line 266: VDSGroup cluster = getVdsGroup(); Line 267: if (cluster != null && FeatureSupported.jsonProtocol(cluster.getcompatibility_version())) { > Doesn't that mean that JSON will be the standard? Correct. Line 268: vdsStatic.setProtocol(VdsProtocol.STOMP); Line 269: } else { Line 270: vdsStatic.setProtocol(VdsProtocol.XML); Line 271: } http://gerrit.ovirt.org/#/c/29123/6/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 326: select fn_db_add_config_value('JsonProtocolSupported','false','3.1'); Line 327: select fn_db_add_config_value('JsonProtocolSupported','false','3.2'); Line 328: select fn_db_add_config_value('JsonProtocolSupported','false','3.3'); Line 329: select fn_db_add_config_value('JsonProtocolSupported','false','3.4'); Line 330: > What about 3.5? 3.5 uses default value which is set to true. This is common pattern here. Line 331: -- by default use no proxy Line 332: select fn_db_add_config_value('SpiceProxyDefault','','general'); Line 333: Line 334: --Handling Install virtualization software on Add Host -- To view, visit http://gerrit.ovirt.org/29123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63e857be667095f62de7ed5e6a81b25a41e917f4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
