Daniel Erez has posted comments on this change. Change subject: core: Add templates to the return value of query ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29702/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java: Line 35: for (String ovf : ovfList) { Line 36: try { Line 37: if (ovfManager.IsOvfTemplate(ovf)) { Line 38: VmTemplate vmTemplate = ovfHelper.readVmTemplateFromOvf(ovf); Line 39: List templateDisks = new ArrayList(vmTemplate.getDiskTemplateMap().values()); add generics type: <DiskImage> Line 40: templates.put(vmTemplate, templateDisks); Line 41: } Line 42: } catch (OvfReaderException ex) { Line 43: auditLogOvfLoadError(ex.getName()); Line 36: try { Line 37: if (ovfManager.IsOvfTemplate(ovf)) { Line 38: VmTemplate vmTemplate = ovfHelper.readVmTemplateFromOvf(ovf); Line 39: List templateDisks = new ArrayList(vmTemplate.getDiskTemplateMap().values()); Line 40: templates.put(vmTemplate, templateDisks); s/templates/templateDisksMap Line 41: } Line 42: } catch (OvfReaderException ex) { Line 43: auditLogOvfLoadError(ex.getName()); Line 44: } -- To view, visit http://gerrit.ovirt.org/29702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3af09baee674814418b00254fcf65f48b3961d28 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
