Alexander Wels has uploaded a new change for review. Change subject: webadmin: fix feedback link popup scrollbars ......................................................................
webadmin: fix feedback link popup scrollbars - Add scrollbars to feedback link popup call, so it doesn't open in window that cannot be manipulated. Change-Id: Ib7d6166298409485e1c7eb3bc12ecf79397b5e69 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1107799 Signed-off-by: Alexander Wels <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/WebUtils.java 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/29709/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java index 1992563..d660e7a 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractHeaderPresenterWidget.java @@ -49,7 +49,7 @@ registerHandler(getView().getGuideLink().addClickHandler(new ClickHandler() { @Override public void onClick(ClickEvent event) { - WebUtils.openUrlInNewWindow(windowName, guideUrl, WebUtils.OPTION_SCROLLBARS); + WebUtils.openUrlInNewWindow(windowName, guideUrl); } })); } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/WebUtils.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/WebUtils.java index 8d829ca..35f094e 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/WebUtils.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/WebUtils.java @@ -8,6 +8,12 @@ * constant for the 'scrollbars' window option. */ public static final String OPTION_SCROLLBARS = "scrollbars"; //$NON-NLS-1$ + + /** + * The default options to pass to Window.open when none are specified. + */ + public static final String DEFAULT_OPTIONS = OPTION_SCROLLBARS; + /** * Opens a link on another browser window. * @@ -17,7 +23,7 @@ * The URL to open */ public static void openUrlInNewWindow(final String name, final String url) { - openUrlInNewWindow(name, url, null); + openUrlInNewWindow(name, url, DEFAULT_OPTIONS); } /** -- To view, visit http://gerrit.ovirt.org/29709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7d6166298409485e1c7eb3bc12ecf79397b5e69 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
