Sandro Bonazzola has posted comments on this change.

Change subject: packaging: do not use /var/tmp for engine
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/29708/1/Makefile
File Makefile:

Line 64: PKG_JBOSS_MODULES=$(DATA_DIR)/modules
Line 65: PKG_CACHE_DIR=$(LOCALSTATE_DIR)/cache/$(ENGINE_NAME)
Line 66: PKG_LOG_DIR=$(LOCALSTATE_DIR)/log/$(ENGINE_NAME)
Line 67: PKG_STATE_DIR=$(LOCALSTATE_DIR)/lib/$(ENGINE_NAME)
Line 68: PKG_TMP_DIR=$(PKG_STATE_DIR)/tmp
Please ensure that spec file add %dir on this directory and no other package 
relies on $(LOCALSTATE_DIR)/tmp/$(ENGINE_NAME) (dwh and reports at least)

Also verify it works with selinux enforcing.
Line 69: JBOSS_HOME=/usr/share/jboss-as
Line 70: PYTHON_DIR=$(PYTHON_SYS_DIR)
Line 71: DEV_PYTHON_DIR=
Line 72: PKG_USER=ovirt


-- 
To view, visit http://gerrit.ovirt.org/29708
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88563c8c0d319eb3356b47233a31c82d9e8b84c7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to