Tal Nisan has uploaded a new change for review. Change subject: core: Change duplicate action type values to unique ones ......................................................................
core: Change duplicate action type values to unique ones Since the action type value is supposed to be unique, a test will be added to enforce uniqueness of the action type values prior to that, since we have duplicate values in the VdcActionType class we have to change first the duplicate values to different values to ensure uniqueness Change-Id: I6de787be50f8ef0149805bd0292ece2ab81aa465 Signed-off-by: Tal Nisan <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/76/29776/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java index ffa9b86..7f8e3ce 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java @@ -31,7 +31,7 @@ AddVmInterface(28, ActionGroup.CONFIGURE_VM_NETWORK, false, QuotaDependency.NONE), RemoveVmInterface(29, ActionGroup.CONFIGURE_VM_NETWORK, false, QuotaDependency.NONE), UpdateVmInterface(30, ActionGroup.CONFIGURE_VM_NETWORK, false, QuotaDependency.NONE), - ReorderVmNics(128, ActionGroup.CONFIGURE_VM_NETWORK, false, QuotaDependency.NONE), + ReorderVmNics(17, ActionGroup.CONFIGURE_VM_NETWORK, false, QuotaDependency.NONE), AddDisk(31, ActionGroup.CONFIGURE_VM_STORAGE, QuotaDependency.STORAGE), RegisterDisk(32, ActionGroup.CONFIGURE_VM_STORAGE, QuotaDependency.STORAGE), @Deprecated @@ -140,7 +140,7 @@ TryBackToAllSnapshotsOfVm(223, ActionGroup.MANIPULATE_VM_SNAPSHOTS, QuotaDependency.NONE), RestoreAllSnapshots(224, ActionGroup.MANIPULATE_VM_SNAPSHOTS, QuotaDependency.STORAGE), CopyImageGroup(225, QuotaDependency.STORAGE), - MoveOrCopyDisk(226, QuotaDependency.STORAGE), + MoveOrCopyDisk(228, QuotaDependency.STORAGE), RemoveSnapshotSingleDisk(227, QuotaDependency.STORAGE), CreateCloneOfTemplate(229, QuotaDependency.STORAGE), RemoveDisk(230, QuotaDependency.STORAGE), @@ -235,7 +235,7 @@ AttachStorageDomainToPool(906, ActionGroup.MANIPULATE_STORAGE_DOMAIN, QuotaDependency.NONE), DetachStorageDomainFromPool(907, ActionGroup.MANIPULATE_STORAGE_DOMAIN, QuotaDependency.NONE), ActivateStorageDomain(908, ActionGroup.MANIPULATE_STORAGE_DOMAIN, QuotaDependency.NONE), - ConnectDomainToStorage(916, QuotaDependency.NONE), + ConnectDomainToStorage(912, QuotaDependency.NONE), DeactivateStorageDomain(909, ActionGroup.MANIPULATE_STORAGE_DOMAIN, QuotaDependency.NONE), AddSANStorageDomain(910, ActionGroup.CREATE_STORAGE_DOMAIN, QuotaDependency.NONE), ExtendSANStorageDomain(911, ActionGroup.EDIT_STORAGE_DOMAIN_CONFIGURATION, QuotaDependency.NONE), -- To view, visit http://gerrit.ovirt.org/29776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6de787be50f8ef0149805bd0292ece2ab81aa465 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
