Daniel Erez has uploaded a new change for review. Change subject: core: wrong messages in AddExistingFileStorageDomain ......................................................................
core: wrong messages in AddExistingFileStorageDomain AddExistingFileStorageDomainCommand -> checkExistingStorageDomain: swapped usages of ACTION_TYPE_FAILED_STORAGE_DOMAIN_ALREADY_EXIST and ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_EXIST (as the current output is incorrect). Change-Id: Idebeacf0b9332b54cfbdc62d16da89d8ce3478da Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/29782/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java index 36741f6..8e56616 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java @@ -56,7 +56,7 @@ protected boolean checkExistingStorageDomain() { if (DbFacade.getInstance().getStorageDomainStaticDao().get(getStorageDomain().getId()) != null) { - return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_EXIST); + return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_ALREADY_EXIST); } List<Guid> storageIds = (ArrayList<Guid>) runVdsCommand(VDSCommandType.HSMGetStorageDomainsList, @@ -65,7 +65,7 @@ ).getReturnValue(); if (!storageIds.contains(getStorageDomain().getId())) { - return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_ALREADY_EXIST); + return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_EXIST); } Pair<StorageDomainStatic, Guid> domainFromIrs = (Pair<StorageDomainStatic, Guid>) runVdsCommand( -- To view, visit http://gerrit.ovirt.org/29782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idebeacf0b9332b54cfbdc62d16da89d8ce3478da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
