Hello Idan Shaby,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/29805
to review the following change.
Change subject: core: UpdateStorageDomainCommand's DAOs
......................................................................
core: UpdateStorageDomainCommand's DAOs
Replaced calls to DbFacade.getInstance().getStorageDomainStaticDao()
with getStorageDomainStaticDAO(), as per the backend's convention.
This change is done in order to facilitate writing unit tests for this
class.
Change-Id: I716a662d13512331b4e68ca31a13b6fb559227cd
Signed-off-by: Allon Mureinik <[email protected]>
Signed-off-by: Idan Shaby <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/29805/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java
index 19edd79..d939ac1 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java
@@ -13,7 +13,6 @@
import org.ovirt.engine.core.common.validation.group.UpdateEntity;
import
org.ovirt.engine.core.common.vdscommands.SetStorageDomainDescriptionVDSCommandParameters;
import org.ovirt.engine.core.common.vdscommands.VDSCommandType;
-import org.ovirt.engine.core.dal.dbbroker.DbFacade;
import org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase;
import org.ovirt.engine.core.utils.ObjectIdentityChecker;
@@ -31,7 +30,7 @@
addCanDoActionMessage(VdcBllMessages.VAR__ACTION__UPDATE);
boolean returnValue = super.canDoAction() && checkStorageDomain()
&& checkStorageDomainStatus(StorageDomainStatus.Active) &&
checkStorageDomainNameLengthValid();
- oldDomain =
DbFacade.getInstance().getStorageDomainStaticDao().get(getStorageDomain().getId());
+ oldDomain =
getStorageDomainStaticDAO().get(getStorageDomain().getId());
// Only after validating the existing of the storage domain in DB, we
set the field lastTimeUsedAsMaster in the
// storage domain which is about to be updated.
@@ -77,7 +76,7 @@
@Override
protected void executeCommand() {
-
DbFacade.getInstance().getStorageDomainStaticDao().update(getStorageDomain().getStorageStaticData());
+
getStorageDomainStaticDAO().update(getStorageDomain().getStorageStaticData());
if (_storageDomainNameChanged && getStoragePool() != null) {
runVdsCommand(
VDSCommandType.SetStorageDomainDescription,
--
To view, visit http://gerrit.ovirt.org/29805
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I716a662d13512331b4e68ca31a13b6fb559227cd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Idan Shaby <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
