Vojtech Szocs has posted comments on this change. Change subject: core: enable ConfigValues injection ......................................................................
Patch Set 7: -Code-Review OK, I will answer my first question above :-) I see that in http://gerrit.ovirt.org/#/c/29606/ you have: @Produces @ConfigValue public Integer produceIntConfigValue(InjectionPoint injectionPoint) { return config.get(injectionPoint.getAnnotated().getAnnotation(ConfigValue.class).value()); } @Produces @ConfigValue public String produceStringConfigValue(InjectionPoint injectionPoint) { return config.get(injectionPoint.getAnnotated().getAnnotation(ConfigValue.class).value()); } I assume that CDI injector looks at injected candidate's type (String, Integer, etc.) and calls appropriate @Produces method, right? -- To view, visit http://gerrit.ovirt.org/29539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c4d5f6239d5f4fd7737f9637d1a6e999020b1b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
