Kanagaraj M has posted comments on this change. Change subject: webadmin: introduce disk profiles ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/29672/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/RemoveDiskProfileModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/RemoveDiskProfileModel.java: Line 79: Line 80: protected String getRemoveDiskProfileFullMsg(DiskProfile profile) { Line 81: return ConstantsManager.getInstance() Line 82: .getMessages() Line 83: .diskProfileFromStorageDomain(profile.getName(), profile.getStorageDomainId().toString()); I am not sure StorageDomainId will provide any help here Line 84: } Line 85: Line 86: protected VdcActionParametersBase getRemoveDiskProfileParams(DiskProfile profile) { Line 87: return new DiskProfileParameters(profile, profile.getId()); http://gerrit.ovirt.org/#/c/29672/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/DiskProfilePopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/DiskProfilePopupView.java: Line 65: } Line 66: }); Line 67: qosEditor = new ListModelListBoxEditor<StorageQos>(new NullSafeRenderer<StorageQos>() { Line 68: @Override Line 69: public String renderNullSafe(StorageQos StorageQos) { can this be storageQos? Line 70: return StorageQos.getName(); Line 71: } Line 72: }); Line 73: initWidget(ViewUiBinder.uiBinder.createAndBindUi(this)); -- To view, visit http://gerrit.ovirt.org/29672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5cea3c563cf68efca0468749338a532894f709 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
