Omer Frenkel has posted comments on this change. Change subject: core: send virtio-serial device to VDSM ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29839/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 962: for (VmDevice vmDevice : vmDevices) { Line 963: Map<String, Object> struct = new HashMap<>(); Line 964: struct.put(VdsProperties.Type, VmDeviceGeneralType.CONTROLLER.getValue()); Line 965: struct.put(VdsProperties.Device, VdsProperties.VirtioSerial); Line 966: struct.put(VdsProperties.Index, Integer.toString(0)); why index is needed? what if multiple devices? all with index 0? Line 967: addAddress(vmDevice, struct); Line 968: Line 969: addDevice(struct, vmDevice, null); Line 970: } -- To view, visit http://gerrit.ovirt.org/29839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie99dafc1495f42ffcd76592dcd9130f12c6d61bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
