mooli tayer has posted comments on this change. Change subject: aaa: remove exceptional AdminDomain logic from domain sorting. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29991/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java: Line 29: for (ExtensionProxy extension : extensions) { Line 30: names.add(AuthzUtils.getName(extension)); Line 31: } Line 32: if (getParameters().getFilterInternalDomain()) { Line 33: names.remove(INTERNAL); > What you are saying is to remove the getFilterInternalDomain As far as I could see, this parameter is never used (searched on VdcQueryType.GetDomainList) so i'm removing the parameter class. Line 34: } Line 35: sort(names); Line 36: Line 37: // Return the sorted list: -- To view, visit http://gerrit.ovirt.org/29991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48ff93e74960c082bdd2dce1b15193272946d503 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
