Omer Frenkel has submitted this change and it was merged. Change subject: core: change return value of copyImageVDSCommand for better logging ......................................................................
core: change return value of copyImageVDSCommand for better logging currently the return value of copyImageVDSCommand is not initialized, and is defaulted with emtpy guid. this empty guid appears in the engine.log as the result of the command, which is useless and confusing. Changed the return value to have the vdsm task id, which is a better guid to log there. note that the returnVaule of this command is not in use at all, only the createInfo, so this affect only the log. Change-Id: I80d830dcdcdfa38a76b08e5399b2f916349b9b8e Signed-off-by: Omer Frenkel <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Verified Maor Lipchuk: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80d830dcdcdfa38a76b08e5399b2f916349b9b8e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
