Gilad Chaplik has posted comments on this change. Change subject: common: introduce qos package, and storage qos ......................................................................
Patch Set 17: (2 comments) new patch to follow http://gerrit.ovirt.org/#/c/27093/17/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3024: @DefaultStringValue("Cannot ${action} ${type}. Values are out of range.") Line 3025: String ACTION_TYPE_FAILED_QOS_OUT_OF_RANGE_VALUES(); Line 3026: Line 3027: @DefaultStringValue("Cannot ${action} ${type}. Invalid data center") Line 3028: String ACTION_TYPE_FAILED_QOS_INVALID_DC_ID(); > can we use ACTION_TYPE_FAILED_STORAGE_POOL_NOT_EXIST ? since the file contains the suggested name, I'll use ACTION_TYPE_FAILED_QOS_STORAGE_POOL_NOT_EXIST Line 3029: Line 3030: @DefaultStringValue("QoS name cannot be empty.") Line 3031: String QOS_NAME_NOT_NULL(); Line 3032: http://gerrit.ovirt.org/#/c/27093/17/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 1076: ACTION_TYPE_FAILED_GLUSTER_VOLUME_CANNOT_STOP_REMOVE_BRICK_IN_PROGRESS= Cannot ${action} ${type}. Remove brick operation is running on the volume ${volumeName} in cluster ${vdsGroup}. Line 1077: ACTION_TYPE_FAILED_GLUSTER_OPERATION_INPROGRESS=Cannot ${action} ${type}. Gluster operation is in progress in cluster. Please try again. Line 1078: ACTION_TYPE_FAILED_TAG_ID_REQUIRED=Cannot ${action} ${type}. Tag ID is required. Line 1079: Line 1080: ACTION_TYPE_FAILED_QOS_OUT_OF_RANGE_VALUES=Cannot ${action} ${type}. Values are out of range. > this is not qos-specific message, it is the same as ACTION_TYPE_FAILED_NETW already commented about it in other/previous patches/patch-set. * this patch is for storage QoS only, will aggregate network qos in future 3.5 patch (and remove duplicates). * better messaging will be introduced as well (will open a bug for it). Line 1081: ACTION_TYPE_FAILED_QOS_INVALID_DC_ID=Cannot ${action} ${type}. Invalid data center. Line 1082: Line 1083: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES=Cannot ${action} ${type}. All three values are needed in order to define QoS on each network directions. Line 1084: ACTION_TYPE_FAILED_NETWORK_QOS_NEGATIVE_VALUES=Cannot ${action} ${type}. Negative values are not allowed. -- To view, visit http://gerrit.ovirt.org/27093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
