Omer Frenkel has posted comments on this change. Change subject: dal: Refactor VmDaoDbFacadeImpl row mapping ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29670/1/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 614: CREATE OR REPLACE VIEW vms Line 615: AS Line 616: SELECT vm_static.vm_name as vm_name, vm_static.mem_size_mb as mem_size_mb, vm_static.nice_level as nice_level, vm_static.cpu_shares as cpu_shares, Line 617: vm_static.vmt_guid as vmt_guid, vm_static.os as os, vm_static.description as description, vm_static.free_text_comment as free_text_comment, vm_static.vds_group_id as vds_group_id, Line 618: vm_static.creation_date as creation_date, vm_static.auto_startup as auto_startup, vm_static.is_stateless as is_stateless, please check if/how this affect dwh as they are using the engine db directly also please check with git grep or something, if old names are used somewhere.. for example looks like vm_comment is used in backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java so i assume (guessing, without checking) this patch breaks search vms by comment Line 619: vm_static.is_smartcard_enabled as is_smartcard_enabled, vm_static.is_delete_protected as is_delete_protected, vm_static.sso_method as sso_method, vm_static.dedicated_vm_for_vds as dedicated_vm_for_vds, Line 620: vm_static.fail_back as fail_back, vm_static.default_boot_sequence as default_boot_sequence, vm_static.vm_type as vm_type, vm_pool_map_view.vm_pool_spice_proxy as vm_pool_spice_proxy, Line 621: vds_groups.name as vds_group_name, vds_groups.transparent_hugepages as transparent_hugepages, vds_groups.trusted_service as trusted_service, Line 622: storage_pool.id as storage_pool_id, storage_pool.name as storage_pool_name, -- To view, visit http://gerrit.ovirt.org/29670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa158b5d7a37661cf4c1cc1f01ea4db062a8e11f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
