Vojtech Szocs has posted comments on this change. Change subject: webadmin: host tab sorting ......................................................................
Patch Set 3: (2 comments) A couple of small comments, looks good otherwise. http://gerrit.ovirt.org/#/c/28376/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostHookView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostHookView.java: Line 77: } Line 78: Line 79: @Override Line 80: public int compare(Map<String, String> map1, Map<String, String> map2) { Line 81: return new LexoNumericComparator().compare(map1.get(key), map2.get(key)); Minor thing, I suggest to have: private final LexoNumericComparator lexoNumeric = new LexoNumericComparator(); and in compare() method: return lexoNumeric.compare(map1.get(key), map2.get(key)); (I tend to prefer avoiding instance creation, although in this case, it's not that big of a deal, though.) Line 82: } Line 83: }; http://gerrit.ovirt.org/#/c/28376/3/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ProgressBarColumn.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/ProgressBarColumn.java: Line 57: } Line 58: } Line 59: Line 60: /** Line 61: * Enables default <em>client-side</em> sorting for this column, by the String ordering of the displayed text. I assume you mean "... by the integer value, as returned from getProgressValue method" ? Line 62: */ Line 63: public void makeSortable() { Line 64: makeSortable(new Comparator<T>() { Line 65: -- To view, visit http://gerrit.ovirt.org/28376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf32960b4ad0c2510da2895f86950455766b5237 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
