Vojtech Szocs has posted comments on this change. Change subject: webadmin: user main tab sorting ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28407/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserEventNotifierView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/user/SubTabUserEventNotifierView.java: Line 46: }; Line 47: eventNameColumn.makeSortable(new Comparator<event_subscriber>() { Line 48: @Override Line 49: public int compare(event_subscriber o1, event_subscriber o2) { Line 50: return new LexoNumericComparator().compare(o1.getevent_up_name(), o2.getevent_up_name()); Please consider putting: private final LexoNumericComparator lexoNumeric = new LexoNumericComparator(); in scope of anonymous class declaration, and using it within the compare() method. Line 51: } Line 52: }); Line 53: getTable().addColumn(eventNameColumn, constants.eventNameEventNotifier()); Line 54: -- To view, visit http://gerrit.ovirt.org/28407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87781ecd94ad15fb7db9209c347a57e3bd59db46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
