Vojtech Szocs has posted comments on this change. Change subject: webadmin: Event tab sorting ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28422/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java: Line 70: Line 71: getTable().ensureColumnPresent(AdvancedViewColumns.logTypeColumn, constants.eventIdEvent(), Line 72: advancedViewEnabled, Line 73: "80px"); //$NON-NLS-1$ Line 74: AdvancedViewColumns.userColumn.makeSortable(AuditLogConditionFieldAutoCompleter.USER_NAME); I think that makeSortable() call should be placed near the column declaration, instead of near the column usage. Please consider following code, which uses instance initializer block within a class declaration: ... class AdvancedViewColumns { public static final TextColumnWithTooltip<AuditLog> userColumn = new TextColumnWithTooltip<AuditLog>() { { makeSortable(AuditLogConditionFieldAutoCompleter.USER_NAME); } @Override public String getValue(AuditLog object) { return object.getuser_name(); } }; ... } Line 75: getTable().ensureColumnPresent(AdvancedViewColumns.userColumn, constants.userEvent(), Line 76: advancedViewEnabled, Line 77: "100px"); //$NON-NLS-1$ Line 78: AdvancedViewColumns.hostColumn.makeSortable(AuditLogConditionFieldAutoCompleter.EVENT_HOST); -- To view, visit http://gerrit.ovirt.org/28422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I027d5cd5aa83610384659b873703787a7472f713 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
