anmolbabu has posted comments on this change. Change subject: gluster-nagios-monitoring : Fix for showDashboard incorrect comparison ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29443/3/gluster-nagios-monitoring/src/js/dashboard-init.js File gluster-nagios-monitoring/src/js/dashboard-init.js: Line 9: mod.factory('tabManager', ['pluginApi', '$window', 'urlUtil', function (pluginApi, $window, urlUtil) { Line 10: var tabWindow, selectedTreeItem; Line 11: return { Line 12: addTabs: function () { Line 13: if (pluginApi.configObject().showDashboard && pluginApi.configObject().showDashboard == "true" ) { > Quoting Douglas Crockford: Done :) Line 14: pluginApi.addMainTab('Dashboard', 'dashboard-tab', urlUtil.relativeUrl('dashboard.html')); Line 15: } Line 16: pluginApi.addMainTab('Trends', 'trends-tab', urlUtil.relativeUrl('trendsTab.html')); Line 17: }, -- To view, visit http://gerrit.ovirt.org/29443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c90d8faa3140f6705fe1d6facfaefe376a832dd Gerrit-PatchSet: 3 Gerrit-Project: samples-uiplugins Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Karnan t c <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
