Mike Kolesnik has posted comments on this change. Change subject: core: pool per DC ......................................................................
Patch Set 35: (1 comment) http://gerrit.ovirt.org/#/c/26799/35/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/MacPoolPerDcTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/MacPoolPerDcTest.java: Line 34: import org.ovirt.engine.core.dao.VmDAO; Line 35: import org.ovirt.engine.core.dao.network.VmNicDao; Line 36: import org.ovirt.engine.core.utils.MockConfigRule; Line 37: Line 38: public class MacPoolPerDcTest { > - Try to initialize twice — do you request verifying logging or "not failin * Try to initialize twice - probably you should verify no interactions with the DAOs * Try to create a pool that's already registered - Seems like you throw IllegalStateException so thats what you should expect.. Line 39: Line 40: public static final int MAX_MACS_COUNT_IN_POOL = 100000; Line 41: public static final boolean ALLOW_DUPLICATES = false; Line 42: public static final String MAC_POOL_RANGES = "00:1a:4a:15:c0:00-00:1a:4a:15:c0:ff"; -- To view, visit http://gerrit.ovirt.org/26799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If522a0b0d5f810281bed010b46b5242f7dbdcc29 Gerrit-PatchSet: 35 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
