Omer Frenkel has posted comments on this change. Change subject: core: modify the default value of numa tune mode to interleave. ......................................................................
Patch Set 9: Code-Review-1 (3 comments) marking -1 to avoid merge by mistake, because there is +2 and i want answers first http://gerrit.ovirt.org/#/c/27829/9/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java: Line 103: .addValue("serial_number_policy", vm.getSerialNumberPolicy() == null ? null : vm.getSerialNumberPolicy().getValue()) Line 104: .addValue("custom_serial_number", vm.getCustomSerialNumber()) Line 105: .addValue("is_boot_menu_enabled", vm.isBootMenuEnabled()) Line 106: .addValue("numatune_mode", Line 107: vm.getNumaTuneMode() == null ? NumaTuneMode.INTERLEAVE.getValue() : vm.getNumaTuneMode().getValue()) when would this be null? if null is not a valid option, we should have validation for it, no? Line 108: .addValue("is_spice_file_transfer_enabled", vm.isSpiceFileTransferEnabled()) Line 109: .addValue("is_spice_copy_paste_enabled", vm.isSpiceCopyPasteEnabled()); Line 110: } Line 111: http://gerrit.ovirt.org/#/c/27829/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java: Line 181: */ Line 182: private void addNumaSetting(final String compatibilityVersion) { Line 183: if (Boolean.TRUE.equals(Config.<Boolean> getValue(ConfigValues.CpuPinningEnabled, Line 184: compatibilityVersion))) { Line 185: NumaTuneMode numaTune = vm.getNumaTuneMode() == null ? NumaTuneMode.INTERLEAVE : vm.getNumaTuneMode(); when would this be null? if null is not a valid option, we should have validation for it, no? Line 186: List<VmNumaNode> vmNumaNodes = DbFacade.getInstance().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(vm.getId()); Line 187: List<VdsNumaNode> totalVdsNumaNodes = DbFacade.getInstance().getVdsNumaNodeDAO() Line 188: .getAllVdsNumaNodeByVdsId(vm.getRunOnVds()); Line 189: List<Integer> totalVdsNumaNodesIndexes = NumaUtils.getNodeIndexList(totalVdsNumaNodes); http://gerrit.ovirt.org/#/c/27829/9/packaging/dbscripts/upgrade/03_05_0450_set_default_value_for_numa_tune_mode.sql File packaging/dbscripts/upgrade/03_05_0450_set_default_value_for_numa_tune_mode.sql: Line 1: update vm_static set numatune_mode ='interleave'; i guess we need new upgrade script for users already having this script run for them. -- To view, visit http://gerrit.ovirt.org/27829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie644b17c26dbde9da87875b953ef3fbb0089c1e6 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
