Michael Kublin has posted comments on this change. Change subject: engine:VM with remaining disks will not be deleted.(#822051) ......................................................................
Patch Set 5: (5 inline comments) "I don't understand why only update for disks will reduce performence" - because these is an unneeded operation which was not done before, and it is needed only at 1% of cases, but unneeded query will run at 100% of cases. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java Line 32: private boolean hasImages; If u don't know java Line 224: // Get all disk images for VM (VM should not have any image disk associated with it). Why I need to run query at case that remove successes? Line 233: imagesLeftInVm = true; The answer that the whole EndVmCommand runs inside same transaction is enough, but your answer I still don't understand Line 237: } By the way additional query, inside is get and update, what for? Line 239: } "Yes VM will be left with those two remained disks with ILLEGAL. User can now remove the VM again with those disks." And for what? How these helps me ? The garbage is still left at vdsm and now we have vm at db that we can not do with it anything. Old behaviour - we failed to remove a first disk, even did not send a call to vdsm, vm left as is. Your fix all disks will be marked as ILLEGAL -- To view, visit http://gerrit.ovirt.org/5806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
