Juan Hernandez has uploaded a new change for review. Change subject: sdk: Avoid NPE when receiving null lists ......................................................................
sdk: Avoid NPE when receiving null lists Currently we don't check if the received list of headers is null, and this causes a NPE. Change-Id: I5a844fb0e69330a7b1f3949802f016a27391b113 Bug-Url: https://bugzilla.redhat.com/1119812 Signed-off-by: Juan Hernandez <[email protected]> (cherry picked from commit ced0ae61b470c8de1837d60c7e45b4806c7a4575) --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxy.java 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-sdk-java refs/changes/17/30117/1 diff --git a/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxy.java b/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxy.java index a70448a..5904d03 100644 --- a/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxy.java +++ b/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxy.java @@ -167,9 +167,11 @@ // The Apache web server ignores the "Expect" header, so if this header was explicitly added by the user, then // we need to add the alternative "X-Ovirt-Expect" as well: - for (Header header : headers) { - if (EXPECT_HEADER.equalsIgnoreCase(header.getName())) { - request.setHeader(ALTERNATIVE_EXPECT_HEADER, header.getValue()); + if (headers != null) { + for (Header header : headers) { + if (EXPECT_HEADER.equalsIgnoreCase(header.getName())) { + request.setHeader(ALTERNATIVE_EXPECT_HEADER, header.getValue()); + } } } -- To view, visit http://gerrit.ovirt.org/30117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5a844fb0e69330a7b1f3949802f016a27391b113 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.5 Gerrit-Owner: Juan Hernandez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
