Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Implement permission sorting by role icon
......................................................................

webadmin: Implement permission sorting by role icon

Implemented sorting for permission subtabs according to the role icon
(ordinary user is lesser than administrator).

Change-Id: I3a2c97315bda060e44b662562e1e08652881d72f
Bug-Url: https://bugzilla.redhat.com/1120054
Signed-off-by: Lior Vernia <[email protected]>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/PermissionTypeColumn.java
1 file changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/30149/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/PermissionTypeColumn.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/PermissionTypeColumn.java
index 6ebde3b..92ccc56 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/PermissionTypeColumn.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/PermissionTypeColumn.java
@@ -1,5 +1,7 @@
 package org.ovirt.engine.ui.common.widget.table.column;
 
+import java.util.Comparator;
+
 import org.ovirt.engine.core.common.businessentities.Permissions;
 
 import com.google.gwt.resources.client.ImageResource;
@@ -9,6 +11,20 @@
  */
 public class PermissionTypeColumn extends ImageResourceColumn<Permissions> {
 
+    public PermissionTypeColumn() {
+        makeSortable(new Comparator<Permissions>() {
+
+            @Override
+            public int compare(Permissions o1, Permissions o2) {
+                if (getValue(o1).equals(getValue(o2))) {
+                    return 0;
+                } else {
+                    return 
(getCommonResources().userImage().equals(getValue(o1))) ? -1 : 1;
+                }
+            }
+        });
+    }
+
     @Override
     public ImageResource getValue(Permissions user) {
         switch (user.getRoleType()) {


-- 
To view, visit http://gerrit.ovirt.org/30149
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a2c97315bda060e44b662562e1e08652881d72f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to