Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Render Providers main tab columns sortable
......................................................................

webadmin: Render Providers main tab columns sortable

Rendered columns sortable via server-side sorting.

Change-Id: I5843296ec00aebc3bca8e90a39dff3d2ad6541a4
Bug-Url: https://bugzilla.redhat.com/1120054
Signed-off-by: Lior Vernia <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java
2 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/30151/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
index 9cf3594..b881e60 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderListModel.java
@@ -159,11 +159,17 @@
 
     @Override
     protected void syncSearch() {
-        SearchParameters tempVar = new SearchParameters(getSearchString(), 
SearchType.Provider, isCaseSensitiveSearch());
+        SearchParameters tempVar =
+                new SearchParameters(applySortOptions(getSearchString()), 
SearchType.Provider, isCaseSensitiveSearch());
         tempVar.setMaxCount(getSearchPageSize());
         super.syncSearch(VdcQueryType.Search, tempVar);
     }
 
+    @Override
+    public boolean supportsServerSideSorting() {
+        return true;
+    }
+
     private void add() {
         if (getWindow() != null) {
             return;
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java
index f2fb79a..45c8895 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabProviderView.java
@@ -2,6 +2,7 @@
 
 import org.ovirt.engine.core.common.businessentities.Provider;
 import org.ovirt.engine.core.common.businessentities.ProviderType;
+import org.ovirt.engine.core.searchbackend.ProviderConditionFieldAutoCompleter;
 import org.ovirt.engine.ui.common.idhandler.ElementIdHandler;
 import org.ovirt.engine.ui.common.uicommon.model.MainModelProvider;
 import org.ovirt.engine.ui.common.widget.table.column.EnumColumn;
@@ -45,6 +46,7 @@
                 return object.getName();
             }
         };
+        nameColumn.makeSortable(ProviderConditionFieldAutoCompleter.NAME);
 
         getTable().addColumn(nameColumn, constants.nameProvider(), "200px"); 
//$NON-NLS-1$
 
@@ -54,6 +56,7 @@
                 return object.getType();
             }
         };
+        typeColumn.makeSortable(ProviderConditionFieldAutoCompleter.TYPE);
 
         getTable().addColumn(typeColumn, constants.typeProvider(), "200px"); 
//$NON-NLS-1$
 
@@ -63,6 +66,7 @@
                 return object.getDescription();
             }
         };
+        
descriptionColumn.makeSortable(ProviderConditionFieldAutoCompleter.DESCRIPTION);
 
         getTable().addColumn(descriptionColumn, 
constants.descriptionProvider(), "300px"); //$NON-NLS-1$
 
@@ -72,6 +76,7 @@
                 return object.getUrl();
             }
         };
+        urlColumn.makeSortable(ProviderConditionFieldAutoCompleter.URL);
 
         getTable().addColumn(urlColumn, constants.urlProvider(), "200px"); 
//$NON-NLS-1$
 


-- 
To view, visit http://gerrit.ovirt.org/30151
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5843296ec00aebc3bca8e90a39dff3d2ad6541a4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to