Juan Hernandez has uploaded a new change for review. Change subject: restapi: Remove leading / from RSDL action names ......................................................................
restapi: Remove leading / from RSDL action names The action names in the RSDL metadata files contain leading slashes. Durign generation of the RSDL document these are compared to the generated links, which are relative, they don't have slashes. As a result the generated RSDL document doesn't contain the information extracted from the metadata file. Change-Id: I37a39943f23406a3e6c077317c0b5159f85626f6 Bug-Url: https://bugzilla.redhat.com/1102772 Signed-off-by: Juan Hernandez <[email protected]> (cherry picked from commit 5723ef221dd9f3ea4dc2e10eecf1ae8576cd7e08) --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/30258/1 diff --git a/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java b/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java index 7cb4417..ecbe998 100644 --- a/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java +++ b/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/rsdl/RsdlManager.java @@ -144,11 +144,19 @@ } private static MetaData loadMetaData() throws IOException { + // Load the metadata file: InputStream stream = RsdlManager.class.getResourceAsStream(METADATA_FILE_NAME); Constructor constructor = new CustomClassLoaderConstructor(Thread.currentThread().getContextClassLoader()); - Object result = new Yaml(constructor).load(stream); + MetaData metaData = (MetaData) new Yaml(constructor).load(stream); stream.close(); - MetaData metadata = (MetaData) result; - return metadata; + + // Remove leading slashes from all the action names: + for (Action action : metaData.getActions()) { + String name = action.getName(); + name = name.replaceAll("^/?", ""); + action.setName(name); + } + + return metaData; } } -- To view, visit http://gerrit.ovirt.org/30258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I37a39943f23406a3e6c077317c0b5159f85626f6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
