Moti Asayag has posted comments on this change. Change subject: tools: Adding Reload Configs Implementation ......................................................................
Patch Set 5: (5 inline comments) .................................................... File backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java Line 68: please move this portion of constants before the class members, where the other constants are included. Line 84: private static final String SSL_IGNORE_HOST_VERIFICATION = "SSL_IGNORE_HOST_VERIFICATION"; same Line 539: engineConn.setReadTimeout(30000); please move to constant .................................................... File backend/manager/tools/engine-config/src/main/resources/engine-config Line 40: printf "### Filtering reloadable for list action is Tech Preview.\n" please replace tabs with spaces .................................................... File backend/manager/tools/engine-tools-common/src/main/java/org/ovirt/engine/core/tools/common/SSLSocketFactoryCreator.java Line 15: One major reason i can think of is that the engine-config doesn't depend on any ovirt-engine library. By using the AuthSSLProtocolSocketFactory we introduce a dependency on the utils (and recursively on compat and common). -- To view, visit http://gerrit.ovirt.org/4951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9e790d7a8386359edfd62172df1078da033e91 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
