Alona Kaplan has posted comments on this change. Change subject: webadmin: Reset properties when detaching network ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/30496/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java: Line 53: if (netParams != null) { Line 54: targetNic.getEntity().setBootProtocol(netParams.getBootProtocol()); Line 55: targetNic.getEntity().setAddress(netParams.getAddress()); Line 56: targetNic.getEntity().setSubnet(netParams.getSubnet()); Line 57: targetNic.getEntity().setGateway(netParams.getGateway()); The CustomProperties should also be set here. Line 58: } else { Line 59: if (targetNic.getEntity().getBootProtocol() == null) { Line 60: if (!isManagement()) { Line 61: targetNic.getEntity().setBootProtocol(NetworkBootProtocol.NONE); Line 89: if (netParams != null) { Line 90: bridge.setBootProtocol(netParams.getBootProtocol()); Line 91: bridge.setAddress(netParams.getAddress()); Line 92: bridge.setSubnet(netParams.getSubnet()); Line 93: bridge.setGateway(netParams.getGateway()); and here Line 94: } else { Line 95: if (bridge.getBootProtocol() == null) { Line 96: if (!isManagement()) { Line 97: bridge.setBootProtocol(NetworkBootProtocol.NONE); Line 130: netParams.setBootProtocol(detachedDevice.getBootProtocol()); Line 131: netParams.setAddress(detachedDevice.getAddress()); Line 132: netParams.setSubnet(detachedDevice.getSubnet()); Line 133: netParams.setGateway(detachedDevice.getGateway()); Line 134: netParams.setCustomProperties(detachedDevice.getCustomProperties()); Shouldn't qos be also set on netParams? Line 135: getSetupModel().getNetworkToLastDetachParams().put(getName(), netParams); Line 136: Line 137: if (!hasVlan()) { Line 138: nicEntity.setNetworkName(null); -- To view, visit http://gerrit.ovirt.org/30496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37f3f1bc0cc3d5353c43d628fa3b24420728236c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
