Yair Zaslavsky has posted comments on this change. Change subject: aaa: NPE when adding permission to datacenter ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/30519/4/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedPermissionsResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedPermissionsResourceTest.java: Line 63: currentUser.setLastName(USER); Line 64: currentUser.setDomain(DOMAIN); Line 65: currentUser.setNamespace(NAMESPACE); Line 66: currentUser.setId(Guid.newGuid()); Line 67: expect(current.get(DbUser.class)).andReturn(currentUser).anyTimes(); > This DbUser mock is potentially used in many places, so it should be create i'll check that thanks Line 68: } Line 69: Line 70: @Test Line 71: @Ignore -- To view, visit http://gerrit.ovirt.org/30519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I379ffbac3e8323cf575d9d14c860dd03a6b6e686 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
