Ori Liel has posted comments on this change. Change subject: restapi: expose host certificate subject in host properties ......................................................................
Patch Set 3: (4 inline comments) .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java Line 331: return this.parent; why did you add getParent()? I don't see you used it anywhere .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java Line 137: VdcQueryReturnValue getVdsCertificateSubjectResult = bad variable name getVdsCertificateSubjectResult .................................................... File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java Line 593: BackendHostsResourceTest.CERTIFICATE_SUBJECT); Looks like all tests now expect a certificate, and no test checks that getting a host without a certificate works. .................................................... File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java Line 345: setUpGetCertificateInfo(1); Same comment as in other test class - no test for scenario of no certificate -- To view, visit http://gerrit.ovirt.org/5984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8716ba5e096b7b86c924385d02ceccef5315d84c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
