Mike Kolesnik has posted comments on this change. Change subject: core: Fix validation of Updating attached network ......................................................................
Patch Set 3: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java Line 172: oldNetworkName = StringUtils.isEmpty(updatedIface.getNetworkName()) ? null : updatedIface.getNetworkName(); Why is it named "oldNetworkName"? It's the new network's name.. Or is it the one that should be updated from the DB? Line 174: addCanDoActionMessage(VdcBllMessages.NETWROK_OLD_NETWORK_NOT_SPECIFIED); I think this message is not suitable for this check. Also, I think this type of check belongs to validation framework checks. (probably in a different patch) Line 196: if (StringUtils.equals(oldNetworkName, NetworkUtils.getEngineNetwork()) Why is this check relevant? If I change management network to not management, this check would return false.. -- To view, visit http://gerrit.ovirt.org/6009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25ab34d64cc4891dba176e1cd11d073f731d2d8a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
