Mike Kolesnik has posted comments on this change. Change subject: core: IdParameters should contain @NotNull validation ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/30569/1//COMMIT_MSG Commit Message: Line 6: Line 7: core: IdParameters should contain @NotNull validation Line 8: Line 9: as requested in CR, IdParameters should contain @NotNull validation Line 10: - removed RemoveMacPoolCommand which is rendered redundant by this s/RemoveMacPoolCommand/RemoveMacPoolByIdParameters/ Line 11: change. Line 12: Line 13: Change-Id: I4cda909ffc16aa3b844faa7c2e7cd323a0769db1 http://gerrit.ovirt.org/#/c/30569/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java: Line 10: import org.ovirt.engine.core.common.businessentities.ActionGroup; Line 11: import org.ovirt.engine.core.common.businessentities.MacPool; Line 12: import org.ovirt.engine.core.common.errors.VdcBllMessages; Line 13: Line 14: public class RemoveMacPoolCommand extends MacPoolCommandBase<IdParameters> { You need to override getValidationGroups otherwise the validation won't occur. Line 15: Line 16: private MacPool oldMacPool; Line 17: Line 18: public RemoveMacPoolCommand(IdParameters parameters) { http://gerrit.ovirt.org/#/c/30569/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/IdParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/IdParameters.java: Line 7: Line 8: public class IdParameters extends VdcActionParametersBase { Line 9: private static final long serialVersionUID = -8078914032408357639L; Line 10: Line 11: @NotNull(groups = { UpdateEntity.class }) Should be RemoveEntity Line 12: private Guid id; Line 13: Line 14: public IdParameters() { Line 15: } -- To view, visit http://gerrit.ovirt.org/30569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cda909ffc16aa3b844faa7c2e7cd323a0769db1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
