Gilad Chaplik has posted comments on this change. Change subject: core, db: add getQosByDiskProfile ......................................................................
Patch Set 2: (1 comment) new patch to follow http://gerrit.ovirt.org/#/c/29814/2/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/StorageQosDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/qos/StorageQosDaoDbFacadeImpl.java: Line 15: super(QosType.STORAGE); Line 16: } Line 17: Line 18: @Override Line 19: public StorageQos getByDiskProfile(Guid diskProfileId) { > - if you already want to save the extra query, let's have this with done wi Done Line 20: // TODO: avoid 2 db queries Line 21: DiskProfile diskProfile = dbFacade.getDiskProfileDao().get(diskProfileId); Line 22: if (diskProfile == null || diskProfile.getQosId() == null) { Line 23: return null; -- To view, visit http://gerrit.ovirt.org/29814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8e9b246172497412b3dc13d46af85fd155713cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
