anmolbabu has posted comments on this change. Change subject: engine : VdsCommand for geo-rep status detail query ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/30472/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeGeoRepStatusDetailForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeGeoRepStatusDetailForXmlRpc.java: Line 27: private static final String DELETES_PENDING = "deletesPending"; Line 28: private static final String FILES_SKIPPED = "filesSkipped"; Line 29: private static final String GEO_REP_PAIRS = "pairs"; Line 30: Line 31: private List<GlusterGeoRepSessionDetails> geoRepDetails = new ArrayList<GlusterGeoRepSessionDetails>(); > These arrays and individual variables look confusing to me. populatePairDetails(Map<String, Object> innerMap) is called per pair detail. So, this function should return 1 GlusterGeoRepSession object and its associated 1 GlusterGeoRepSessionDetails. As I need to return 2 objects from here, I thought of having the objects : GlusterGeoRepSession session; and GlusterGeoRepSessionDetails details; as class variables and set them each time populatePairDetails is called from populateSessionDetails(i.e, for each pair) and putting them in the appropriate lists in populateSessionDetails per pair Line 32: private List<GlusterGeoRepSession> geoRepSessions = new ArrayList<GlusterGeoRepSession>(); Line 33: Line 34: private GlusterGeoRepSessionDetails details; Line 35: private GlusterGeoRepSession session; -- To view, visit http://gerrit.ovirt.org/30472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b8236e7e516eba46d183c3f83a973175edba90f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
