Moti Asayag has posted comments on this change. Change subject: engine: Wrong vnic profiles on vm based on template from another cluster ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/30639/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 1335: protected boolean isValidTemplate() { Line 1336: return getVmTemplate().getStoragePoolId().equals(getStoragePoolId()); Line 1337: } Line 1338: Line 1339: protected void updateProfiles(VmNic iface) { this method updates a single profile, hence should be called "updateProfile" or even "updateVnicProfile" or "updateProfileOnNic" as long as it a singular. in addition, the method can be just private. Line 1340: Network network = NetworkHelper.getNetworkByVnicProfileId(iface.getVnicProfileId()); Line 1341: if (network != null && !NetworkHelper.isNetworkInCluster(network, getVdsGroupId())) { Line 1342: iface.setVnicProfileId(VnicProfileView.EMPTY.getId()); Line 1343: } Line 1338: Line 1339: protected void updateProfiles(VmNic iface) { Line 1340: Network network = NetworkHelper.getNetworkByVnicProfileId(iface.getVnicProfileId()); Line 1341: if (network != null && !NetworkHelper.isNetworkInCluster(network, getVdsGroupId())) { Line 1342: iface.setVnicProfileId(VnicProfileView.EMPTY.getId()); this should be just null. I'm familiar with the EMPTY profile usages on the backend. Line 1343: } Line 1344: } -- To view, visit http://gerrit.ovirt.org/30639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I678c8db0e56c9ba9e9e947028d14ae4ddae76e0a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
