Omer Frenkel has posted comments on this change. Change subject: restapi: Control\view Soundcard property ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/30635/2/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 2630: <xs:element ref="console" minOccurs="0" maxOccurs="1"/> Line 2631: <xs:element name="timezone" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 2632: <xs:element ref="domain" minOccurs="0" maxOccurs="1"/> Line 2633: <xs:element ref="usb" minOccurs="0" maxOccurs="1"/> Line 2634: <xs:element ref="soundcard_enabled" minOccurs="0" maxOccurs="1"/> wouldnt it be enough to use <xs:element name=".." type="xs:boolean"..> ? instead of using element ref? Line 2635: <xs:element name="tunnel_migration" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 2636: <xs:element name="migration_downtime" type="xs:int" minOccurs="0" maxOccurs="1" /> Line 2637: <xs:element ref="virtio_scsi" minOccurs="0" maxOccurs="1"/> Line 2638: <xs:element ref="permissions" minOccurs="0" maxOccurs="1"/> -- To view, visit http://gerrit.ovirt.org/30635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I598cf89b6a5fd4755958cf7b597484c225166460 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
