Frank Kobzik has posted comments on this change. Change subject: core: GetRngDeviceQuery should be a user query ......................................................................
Patch Set 1: Hi, I quickly looked @ our storage procedures and it indeed seems that the filtering is based on vm id (so filtered device queries can only "see" the devices of vms for which user has permissions). However, my implementation uses unfiltered query (using method getVmDeviceByVmIdAndType(...)). I noticed we also expose method that allows passing isFiltered flag (getVmDeviceByVmIdTypeAndDevice(...some args..., boolean isFiltered)). So I think we should use this method and probably filter results all the time. What do you guys think? -- To view, visit http://gerrit.ovirt.org/30619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5589c7185a61c076123aee962c8ea2c097920617 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
