Eli Mesika has posted comments on this change. Change subject: core: custom fencing settings are not save to DB ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/30643/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java: Line 208: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_PM_ENABLED_WITHOUT_AGENT); Line 209: result = false; Line 210: } else if (!Regex.IsMatch(FenceConfigHelper.getFenceConfigurationValue(ConfigValues.VdsFenceType.name(), Line 211: clusterCompatibilityVersion), String.format("(,|^)%1$s(,|$)", Line 212: vdsStatic.getPmType()))) { > Could you please reformat the code to make it more readable? Done Line 213: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_AGENT_NOT_SUPPORTED); Line 214: result = false; Line 215: } Line 216: // Do not allow to pass empty/null value as the user/password agent credentials -- To view, visit http://gerrit.ovirt.org/30643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If41fb226cbb3a80aa2a524e22756a91553dec1b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
